bug #628 avoid >100% progress (IonBazan)

This PR was merged into the 1.7-dev branch.

Discussion
----------

avoid >100% progress

Fixes #468
This change skips tracking the progress of downloads where `Content-Length` header is missing. Curl returns `-1` which resulted in wrong progress calculation (total file size was not added to the total bytes to download).

As soon as such file is downloaded, the progress is updated. This means that downloading one big file might cause progress to stuck until the download is done.

Commits
-------

dcc71c2 avoid >100% progress

Author: nicolas-grekas

.gitignore

@@ -1,4 +1,5 @@
 /vendor/
 /build/
+.phpunit.result.cache
 .php_cs.cache
 composer.lock

.php_cs.dist

@@ -7,8 +7,9 @@ return PhpCsFixer\Config::create()
     ->setRules(array(
         '@Symfony' => true,
         '@Symfony:risky' => true,
+        'fopen_flags' => false,
         '@PHPUnit48Migration:risky' => true,
-        'array_syntax' => array('syntax' => 'short'),
+        'array_syntax' => ['syntax' => 'short'],
         'ordered_imports' => true,
         'php_unit_no_expectation_annotation' => false, // part of `PHPUnitXYMigration:risky` ruleset, to be enabled when PHPUnit 4.x support will be dropped, as we don't want to rewrite exceptions handling twice
         'protected_to_private' => false,

src/CurlDownloader.php

@@ -168,6 +168,8 @@ public function get($origin, $url, $context, $file)
             if ($file && !isset($this->exceptions[(int) $ch])) {
                 $fd = fopen($file, 'rb');
             }
+            $progress = array_diff_key(curl_getinfo($ch), self::$timeInfo);
+            $this->finishProgress($ch, $params['notification'], $progress);
             unset($this->jobs[(int) $ch], $this->exceptions[(int) $ch]);
             curl_multi_remove_handle($this->multiHandle, $ch);
             curl_close($ch);
@@ -186,7 +188,7 @@ public function get($origin, $url, $context, $file)
 
     private function onProgress($ch, callable $notify, array $progress, array $previousProgress)
     {
-        if (300 <= $progress['http_code'] && $progress['http_code'] < 400) {
+        if (300 <= $progress['http_code'] && $progress['http_code'] < 400 || 0 > $progress['download_content_length']) {
             return;
         }
 
@@ -203,4 +205,12 @@ private function onProgress($ch, callable $notify, array $progress, array $previ
             $notify(STREAM_NOTIFY_PROGRESS, STREAM_NOTIFY_SEVERITY_INFO, '', 0, (int) $progress['size_download'], (int) $progress['download_content_length'], false);
         }
     }
+
+    private function finishProgress($ch, callable $notify, array $progress)
+    {
+        if ($progress['download_content_length'] < 0) {
+            $notify(STREAM_NOTIFY_FILE_SIZE_IS, STREAM_NOTIFY_SEVERITY_INFO, '', 0, 0, (int) $progress['size_download'], false);
+            $notify(STREAM_NOTIFY_PROGRESS, STREAM_NOTIFY_SEVERITY_INFO, '', 0, (int) $progress['size_download'], (int) $progress['size_download'], false);
+        }
+    }
 }