avoid >100% progress #628
Merged
avoid >100% progress #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jun 11, 2020
|
Thank you @IonBazan. |
|
is this something that needs to be applied in composer 2 as well ? I know that they reused part of the curl implementation of Flex, but I don't know whether this bug happens in the code they copied or in the code they did not use. |
|
We dropped progress support entirely so should be fine but thanks for asking. |
tgalopin
pushed a commit
to tgalopin/flex
that referenced
this pull request
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #468
This change skips tracking the progress of downloads where
Content-Lengthheader is missing. Curl returns-1which resulted in wrong progress calculation (total file size was not added to the total bytes to download).As soon as such file is downloaded, the progress is updated. This means that downloading one big file might cause progress to stuck until the download is done.