Skip to content

Right trimming configuration data before markers #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2017

Conversation

iammichiel
Copy link

A newline is inserted after the data and before the end-section marker. Inserting empty lines in configuration files.

Fixes #119

A newline is inserted after the data and before the end-section marker. Inserting empty lines in configuration files. 

Fixes symfony#119
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tested this change and it solved the reported issue to me. Thanks!

@fabpot
Copy link
Member

fabpot commented Jul 3, 2017

Thank you @iammichiel.

@fabpot fabpot merged commit 0c24b90 into symfony:master Jul 3, 2017
fabpot added a commit that referenced this pull request Jul 3, 2017
This PR was merged into the 1.0-dev branch.

Discussion
----------

Right trimming configuration data before markers

A newline is inserted after the data and before the end-section marker. Inserting empty lines in configuration files.

Fixes #119

Commits
-------

0c24b90 Right trimming configuration data before markers
tgalopin pushed a commit to tgalopin/flex that referenced this pull request Dec 3, 2020
This PR was merged into the master branch.

Discussion
----------

Fix the Makefile

| Q             | A
| ------------- | ---
| License       | MIT

Alternative fix to symfony#120.

Commits
-------

d8f4d2d Fix the Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants