Skip to content

Removed some unused variables #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Removed some unused variables #2

wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

This was detected with PHPStorm ... but maybe you want to keep them for future usages.

@fabpot
Copy link
Member

fabpot commented Apr 1, 2017

Thank you @javiereguiluz.

@fabpot fabpot closed this in 71f0e85 Apr 1, 2017
SerheyDolgushev added a commit to SerheyDolgushev/flex that referenced this pull request Apr 19, 2020
SerheyDolgushev added a commit to SerheyDolgushev/flex that referenced this pull request Apr 19, 2020
tgalopin pushed a commit to tgalopin/flex that referenced this pull request Dec 3, 2020
…on to Entity/ (javiereguiluz)

This PR was merged into the master branch.

Discussion
----------

[Doctrine] Added an empty Repository/ dir in addition to Entity/

This fixes symfony#31

Commits
-------

75d3156 [Doctrine] Added an empty Repository/ dir in addition to Entity/
fabpot added a commit that referenced this pull request May 1, 2021
…rosier)

This PR was squashed before being merged into the 1.12-dev branch.

Discussion
----------

Fix errors during the upgrade or downgrade of symfony/flex

Composer fails during the upgrade of symfony/flex
```
$ composer create-project symfony/skeleton flex && cd flex
$ composer require symfony/flex dev-main -v
./composer.json has been updated
Running composer update symfony/flex
> pre-update-cmd: Symfony\Flex\Flex_composer_tmp0->configureInstaller
Loading composer repositories with package information
> pre-pool-create: Symfony\Flex\Flex_composer_tmp0->truncatePackages
Updating dependencies
Dependency resolution completed in 0.000 seconds
Analyzed 135 packages to resolve dependencies
Analyzed 210 rules to resolve dependencies
Lock file operations: 0 installs, 1 update, 0 removals
Updates: symfony/flex:dev-main 4d7970f
  - Upgrading symfony/flex (v1.12.2 => dev-main 4d7970f)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
Updates: symfony/flex:dev-main 4d7970f
  - Upgrading symfony/flex (v1.12.2 => dev-main 4d7970f): Extracting archive
PHP Fatal error:  Uncaught ArgumentCountError: Too few arguments to function Symfony\Flex\Command\GenerateIdCommand::__construct(), 0 passed in phar:///usr/local/bin/composer/src/Composer/Plugin/PluginManager.php(213) : eval()'d code on line 278 and exactly 1 expected in /private/tmp/flex/vendor/symfony/flex/src/Command/GenerateIdCommand.php:22
Stack trace:
#0 phar:///usr/local/bin/composer/src/Composer/Plugin/PluginManager.php(213) : eval()'d code(278): Symfony\Flex\Command\GenerateIdCommand->__construct()
#1 phar:///usr/local/bin/composer/src/Composer/Plugin/PluginManager.php(320): Symfony\Flex\Flex_composer_tmp1->activate(Object(Composer\Composer), Object(Composer\IO\ConsoleIO))
#2 phar:///usr/local/bin/composer/src/Composer/Plugin/PluginManager.php(224): Composer\Plugin\PluginManager->addPlugin(Object(Symfony\Flex\Flex_composer_tmp1), false)
#3 phar:///usr/local/bin/composer/src/Composer/Installer/PluginInstaller.php(100): Composer\Plugin\PluginManager->registerPackage(Object(Composer\Package\CompletePackage), true)
#4 [in in /private/tmp/flex/vendor/symfony/flex/src/Command/GenerateIdCommand.php on line 22

Commits
-------

b4eb22d Fix errors during the upgrade or downgrade of symfony/flex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants