[DX] Command to list all available recipes #562

maxhelias · 2019-09-18T14:33:26Z

First step of #518, the command symfony:recipes:show and alias symfony:recipes

Result :

I need feedback on the disposition and maybe i can add the version of the recipe installed like

doctrine/annontations 1.0

Tell me what you think :)

Note: the last section is currently commented out, and will be added later

src/Command/RecipesCommand.php

src/Flex.php

src/InformationOperation.php

maxhelias · 2019-11-06T08:52:49Z

friendly ping @weaverryan 😄

weaverryan · 2019-11-07T01:19:42Z

src/Command/RecipesCommand.php

+        //$write[] = '';
+        //$write[] = '<fg=blue>Run</>:';
+        //$write[] = ' * composer symfony:recipes vendor/package to see details about a recipe.';
+        //$write[] = ' * composer symfony:recipes:update vendor/package to update that recipe.';


I think to make this new command "complete", we would need to at least be able to show 2 commands down here:

A) A command to "update" a single recipe - so symfony:recipe:update - item (3) from #518
B) A command to "install" missing recipes - so symfony:recipe:install - item (2) from #518

The symfony:recipes vendor/package or whatever we call it - item (4) from #518 would be super nice to have, as would symfony:recipes:blame - but those could come later.

I started the symfony:recipes vendor/package in this command. I will update this PR when it's ready

The symfony:recipes:install is ready here : Rename SyncRecipes on InstallRecipes #565

For the symfony:recipes:update, it would be better to have some feedback on the Rename SyncRecipes on InstallRecipes #565 before I start it

And for the symfony:recipes:blame, it will be a lot more complicated and I agree to do it later

maxhelias · 2019-11-13T14:34:57Z

I updated the PR, there is now the possibility to inspect only one recipe
Here is an overview, make suggestions for the final rendering 😉

src/Command/RecipesCommand.php

This PR was merged into the 1.5-dev branch. Discussion ---------- Allowing specific recipes to be "re-installed" Hi! Very simple: you can now re-install/update just one (or specific) recipes: ``` composer symfony:sync-recipes symfony/console --force ``` That's very helpful, as there are a few specific recipes (this is one of them) that really *do* need to be "updated", at the very least, when upgrading to Symfony 5 (as some important files have evolved over time). This relates to #575 (will help with upgrading), #518 and should go along with the PRs #562 and #565 Thanks! Commits ------- a9dad87 Allowing specific recipes to be "re-installed"

src/Command/RecipesCommand.php

weaverryan

nit picks :)

src/Command/RecipesCommand.php

src/Flex.php

weaverryan

This is ready - dependent on #565 (just because this command references the new/renamed recipes:installcommand).

nicolas-grekas · 2019-12-13T14:39:59Z

Can you please rebase the PR?
Maybe also update the screenshots to help next reviewers?

maxhelias · 2019-12-13T16:12:55Z

Here is the result :

nicolas-grekas · 2019-12-13T16:34:05Z

Thank you @maxhelias.

This PR was squashed before being merged into the 1.5-dev branch. Discussion ---------- [DX] Command to list all available recipes First step of #518, the command `symfony:recipes:show` and alias `symfony:recipes` Result : <img width="701" alt="Capture d’écran 2019-09-18 à 15 46 09" src="https://user-images.githubusercontent.com/12966574/70814407-b4f8eb00-1dcb-11ea-9118-454d444cd22d.png"> I need feedback on the disposition and maybe i can add the version of the recipe installed like - doctrine/annontations 1.0 Tell me what you think :) Note: the last section is currently commented out, and will be added later Commits ------- f73fba0 [DX] Command to list all available recipes

nicolas-grekas · 2019-12-13T16:39:36Z

(dunno what happened to the attached patch but the commit is in:
77a0cc9)

… (weaverryan) This PR was squashed before being merged into the 1.5-dev branch. Discussion ---------- Adding the current recipe URL to recipes <recipe> output Hi! This replaces #585 and builds off of #562. Basically, I *thought* that it would be nearly impossible to get the *exact* git sha for when a recipe is installed. But with a few API calls to GitHub, it's quite possible :). This gives us the ability to (at least) give the URL to the *exact* state of the recipe when it was installed in their app. This can help them determine what's changed and if they need to update. Giving them a "diff" URL would be even more awesome - but as the directory often changes - I don't believe there is any URL we can give to visually compare across directories. Output: <img width="1278" alt="Screen Shot 2019-12-12 at 12 06 54 PM" src="https://user-images.githubusercontent.com/121003/70733308-13dd3800-1cd8-11ea-85c8-61c3283dc1b4.png"> The "installed recipe" is the line that this enables. The "new commits" line (unfortunately) can only be shown when the version/directory of the recipe hasn't changed. There's just not good way (that I can think of) to show a decent history if they are upgrading from (for example) `symfony/framework/bundle/3.3` to `symfony/framework-bundle/4.2`. Cheers! Commits ------- a761365 Adding the current recipe URL to recipes <recipe> output

maxhelias force-pushed the feature/recipe-list branch from b423b27 to 7abec16 Compare September 18, 2019 14:37

weaverryan reviewed Sep 18, 2019

View reviewed changes

maxhelias force-pushed the feature/recipe-list branch 2 times, most recently from 032d7d6 to 5ed8416 Compare September 19, 2019 15:29

maxhelias force-pushed the feature/recipe-list branch from 5ed8416 to f26a79a Compare October 10, 2019 08:17

maxhelias requested a review from weaverryan October 10, 2019 08:20

weaverryan reviewed Nov 7, 2019

View reviewed changes

maxhelias force-pushed the feature/recipe-list branch from f26a79a to 96a33d4 Compare November 7, 2019 12:48

weaverryan reviewed Dec 8, 2019

View reviewed changes

weaverryan mentioned this pull request Dec 8, 2019

Allowing specific recipes to be "re-installed" #583

Merged

maxhelias force-pushed the feature/recipe-list branch 2 times, most recently from bfc6676 to a8d5c94 Compare December 9, 2019 22:48

weaverryan reviewed Dec 11, 2019

View reviewed changes