Support more than just "master" as the default branch #648
Conversation
| (isset($branchAliases['dev-next']) && $alias = $branchAliases['dev-next']) || | ||
| (isset($branchAliases['dev-current']) && $alias = $branchAliases['dev-current']) || | ||
| (isset($branchAliases['dev-support']) && $alias = $branchAliases['dev-support']) || | ||
| (isset($branchAliases['dev-tip']) && $alias = $branchAliases['dev-tip']) || |
There was a problem hiding this comment.
Why do we even have all these cases ? To match the behavior of composer, only $branchAliases[$version] should be relevant. Branch aliases defined for other branches are totally ignored by composer (though they are allowed, so that you don't have to remove them between branches which would be a mess)
There was a problem hiding this comment.
This looks at the branch-alias to decide which version of the recipe should be installed.
We can support more items than composer here.
There was a problem hiding this comment.
checking the branch alias of dev-tip when the installed version is not dev-tip looks weird to me. You want to install the recipe for the installed version, not for a random version.
There was a problem hiding this comment.
It's still pretty common when checking out a custom dev-branch without aliasing it. E.g. for Symfony components, falling back to the dev-master alias is the best way to guess the version of the branch. That's why there is logic IIUC.
No description provided.