feat: allow to enable Docker support using an env var #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
approved these changes
Jun 11, 2021
nicolas-grekas
requested changes
Jun 11, 2021
|
Good idea @nicolas-grekas! It works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's not possible to execute the Docker-related configurators when running
composer create-projectbecause of a chicken and egg problem: thecomposer.jsonfile doesn't exist yet, so it's not possible to setextra.symfony.dockertotrue. This PR allows to enable the Docker support by setting an environment variable calledSYMFONY_DOCKER.Needed by dunglas/symfony-docker#152.