Avoid errors with an older global install of Flex #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
May 27, 2023
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
Oct 22, 2023
…aded (weaverryan) This PR was squashed before being merged into the 1.x branch. Discussion ---------- [Bug] Fix Flex not installing recipes while it is being upgraded Fixes #977 Here's the lifecycle: A) Packages are installed/updated and `Flex::recordOperations()` is called. B) Composer sees that `symfony/flex` is updated and unloads the plugin and reloads it under a new `Symfony\Flex\Flex_composer_tmp0` class. This results in the `Flex::$operations` property being lost. C) And so, no recipes are installed. This PR "stashes" the operations directly on `Symfony/Flex/Flex` where we then read them later. Tested locally. Amazing, it seems to work perfectly. Also, backports #976 to 1.x - my fault for making the PR on the wrong branch. Cheers! Commits ------- 62f7874 [Bug] Fix Flex not installing recipes while it is being upgraded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
When I tried 2.3.0 locally, I it exploded, complaining about:
Btw, the fix for this is running
composer global up symfony/flex.