Merge pull request #1136 from faibl/main

use method add() instead of [] in collection adder-method

Author: jrushlow

src/Util/ClassSourceManipulator.php

@@ -615,11 +615,10 @@ private function addCollectionRelation(BaseCollectionRelation $relation): void
 
         // append the item
         $ifNotContainsStmt->stmts[] = new Node\Stmt\Expression(
-            new Node\Expr\Assign(
-                new Node\Expr\ArrayDimFetch(
-                    new Node\Expr\PropertyFetch(new Node\Expr\Variable('this'), $relation->getPropertyName())
-                ),
-                new Node\Expr\Variable($argName)
+            new Node\Expr\MethodCall(
+                new Node\Expr\PropertyFetch(new Node\Expr\Variable('this'), $relation->getPropertyName()),
+                'add',
+                [new Node\Expr\Variable($argName)]
             ));
 
         // set the owning side of the relationship

tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/Client.php

@@ -65,7 +65,7 @@ public function getTags(): Collection
     public function addTag(Tag $tag): self
     {
         if (!$this->tags->contains($tag)) {
-            $this->tags[] = $tag;
+            $this->tags->add($tag);
         }
 
         return $this;

tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/User.php

@@ -56,7 +56,7 @@ public function getAvatars(): Collection
     public function addAvatar(UserAvatar $avatar): self
     {
         if (!$this->avatars->contains($avatar)) {
-            $this->avatars[] = $avatar;
+            $this->avatars->add($avatar);
             $avatar->setUser($this);
         }
 
@@ -91,7 +91,7 @@ public function getTags(): Collection
     public function addTag(Tag $tag): self
     {
         if (!$this->tags->contains($tag)) {
-            $this->tags[] = $tag;
+            $this->tags->add($tag);
         }
 
         return $this;

tests/Doctrine/fixtures/expected_overwrite/src/Entity/Client.php

@@ -65,7 +65,7 @@ public function getTags(): Collection
     public function addTag(Tag $tag): self
     {
         if (!$this->tags->contains($tag)) {
-            $this->tags[] = $tag;
+            $this->tags->add($tag);
         }
 
         return $this;

tests/Doctrine/fixtures/expected_overwrite/src/Entity/User.php

@@ -67,7 +67,7 @@ public function getAvatars(): Collection
     public function addAvatar(UserAvatar $avatar): self
     {
         if (!$this->avatars->contains($avatar)) {
-            $this->avatars[] = $avatar;
+            $this->avatars->add($avatar);
             $avatar->setUser($this);
         }
 
@@ -102,7 +102,7 @@ public function getTags(): Collection
     public function addTag(Tag $tag): self
     {
         if (!$this->tags->contains($tag)) {
-            $this->tags[] = $tag;
+            $this->tags->add($tag);
         }
 
         return $this;

tests/Doctrine/fixtures/expected_xml/src/Entity/UserXml.php

@@ -47,7 +47,7 @@ public function getAvatars(): Collection
     public function addAvatar(UserAvatar $avatar): self
     {
         if (!$this->avatars->contains($avatar)) {
-            $this->avatars[] = $avatar;
+            $this->avatars->add($avatar);
             $avatar->setUser($this);
         }
 

tests/Util/fixtures/add_many_to_many_relation/User_simple_inverse.php

@@ -38,7 +38,7 @@ public function getRecipes(): Collection
     public function addRecipe(Recipe $recipe): self
     {
         if (!$this->recipes->contains($recipe)) {
-            $this->recipes[] = $recipe;
+            $this->recipes->add($recipe);
             $recipe->addFood($this);
         }
 

tests/Util/fixtures/add_many_to_many_relation/User_simple_no_inverse.php

@@ -38,7 +38,7 @@ public function getRecipes(): Collection
     public function addRecipe(Recipe $recipe): self
     {
         if (!$this->recipes->contains($recipe)) {
-            $this->recipes[] = $recipe;
+            $this->recipes->add($recipe);
         }
 
         return $this;

tests/Util/fixtures/add_many_to_many_relation/User_simple_owning.php

@@ -38,7 +38,7 @@ public function getRecipes(): Collection
     public function addRecipe(Recipe $recipe): self
     {
         if (!$this->recipes->contains($recipe)) {
-            $this->recipes[] = $recipe;
+            $this->recipes->add($recipe);
         }
 
         return $this;

tests/Util/fixtures/add_one_to_many_relation/User_simple.php

@@ -38,7 +38,7 @@ public function getAvatarPhotos(): Collection
     public function addAvatarPhoto(UserAvatarPhoto $avatarPhoto): self
     {
         if (!$this->avatarPhotos->contains($avatarPhoto)) {
-            $this->avatarPhotos[] = $avatarPhoto;
+            $this->avatarPhotos->add($avatarPhoto);
             $avatarPhoto->setUser($this);
         }
 

tests/Util/fixtures/add_one_to_many_relation/User_simple_orphan_removal.php

@@ -38,7 +38,7 @@ public function getAvatarPhotos(): Collection
     public function addAvatarPhoto(UserAvatarPhoto $avatarPhoto): self
     {
         if (!$this->avatarPhotos->contains($avatarPhoto)) {
-            $this->avatarPhotos[] = $avatarPhoto;
+            $this->avatarPhotos->add($avatarPhoto);
             $avatarPhoto->setUser($this);
         }
 

tests/Util/fixtures/add_one_to_many_relation/User_with_use_statements.php

@@ -41,7 +41,7 @@ public function getAvatarPhotos(): Collection
     public function addAvatarPhoto(UserAvatarPhoto $avatarPhoto): self
     {
         if (!$this->avatarPhotos->contains($avatarPhoto)) {
-            $this->avatarPhotos[] = $avatarPhoto;
+            $this->avatarPhotos->add($avatarPhoto);
             $avatarPhoto->setUser($this);
         }