[ci] use annotations when attributes are not supported #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
force-pushed
the
fix/ci-attribute-failures
branch
from
4d1c29e to
1812c0a
Compare
jrushlow
changed the title
|
CI test failures are related to panther tests in 4.4 and make registration tests. |
jrushlow
force-pushed
the
fix/ci-attribute-failures
branch
from
1812c0a to
04f8fea
Compare
jrushlow
force-pushed
the
fix/ci-attribute-failures
branch
from
f4b9628 to
00797b6
Compare
|
Thanks Jesse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DoctrineBundle>=2.4's flex recipe uses attributes by default - regardless if you're using PHP <8.0. We need to use attributes in our tests by default unless doctrine and/or php does not support them.