[ci] handle when@test for doctrine #1067
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DoctrineBundle >= 2.4 Flex Recipe uses
when@test
in theconfig/packages/doctrine.yaml
file instead of a separateconfig/packages/test/doctrine.yaml
file.Prior to this PR we were removing the
test/doctrine.yaml
file because we did not want to use the_test
database suffix in our tests. Now we remove thedbname_suffix
property if it isset in the test environment. For BC, we still remove thetest/doctrine.yaml
file.We could remove then entire
when@test
property fromdoctrine.yaml
, but it would probably be best to do this if something changes to the recipe in the future that warrants the removal. (Something may be added that we don't want to remove in the future as well.)