Skip to content

[ci] handle when@test for doctrine #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Feb 14, 2022

DoctrineBundle >= 2.4 Flex Recipe uses when@test in the config/packages/doctrine.yaml file instead of a separate config/packages/test/doctrine.yaml file.

Prior to this PR we were removing the test/doctrine.yaml file because we did not want to use the _test database suffix in our tests. Now we remove the dbname_suffix property if it isset in the test environment. For BC, we still remove the test/doctrine.yaml file.

We could remove then entire when@test property from doctrine.yaml, but it would probably be best to do this if something changes to the recipe in the future that warrants the removal. (Something may be added that we don't want to remove in the future as well.)

@jrushlow
Copy link
Collaborator Author

Test failures are related to MakeRegistrationTests and a flex issue specific to Symfony 4.4.

@weaverryan
Copy link
Member

Thanks Jesse!

@weaverryan weaverryan merged commit 64318ec into symfony:main Feb 14, 2022
@jrushlow jrushlow deleted the ci/handle-when-at-test branch February 15, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants