Skip to content

Ignore fake file created after running tests and reorder .gitignore #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2022
Merged

Ignore fake file created after running tests and reorder .gitignore #1069

merged 2 commits into from
Feb 15, 2022

Conversation

bocharsky-bw
Copy link
Contributor

After running tests the repo is in a dirty state - the /fake file is created in the root dir.

Also, I reordered .gitignore file here

jrushlow
jrushlow approved these changes Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool beans! Thanks @bocharsky-bw

@jrushlow jrushlow merged commit 5f37ba1 into symfony:main Feb 15, 2022
@bocharsky-bw bocharsky-bw deleted the ignore-fake branch February 15, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bocharsky-bw @jrushlow