Skip to content

[make:registration-form] Translate reasons for VerifyEmailBundle if translator available #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bocharsky-bw
Copy link
Contributor

Exception reasons were translated in SymfonyCasts/verify-email-bundle#103 that allows us to translate them with Maker bundle out of the box if Translator is available.

This PR is similar to #1059 but for VerifyEmailBundle

Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Thanks @bocharsky-bw

@jrushlow jrushlow merged commit fbeee59 into symfony:main Feb 23, 2022
@bocharsky-bw bocharsky-bw deleted the verify-email-bundle-translate-reasons branch February 23, 2022 19:34
@jrushlow jrushlow mentioned this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants