Skip to content

[make:controller] doctrine/annotations is not needed #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Dec 29, 2022

Attribute support for make:controller was added in #725.
PHP 7 support was dropped in #1122

Attributes are always used when using PHP 8...

@jrushlow jrushlow added the Bug Bug Fix label Dec 29, 2022
@jrushlow jrushlow changed the title [make:controller] drop annotation support [make:controller] doctrine/annotations is not needed Dec 29, 2022
@jrushlow jrushlow marked this pull request as ready for review December 29, 2022 02:30
@jrushlow jrushlow requested a review from OskarStark December 29, 2022 02:32
@jrushlow jrushlow added the Status: Needs Review Needs to be reviewed label Dec 29, 2022
@jrushlow jrushlow merged commit d6eb1d8 into symfony:main Jan 3, 2023
@jrushlow jrushlow deleted the fix/make-controller-annotations branch January 3, 2023 07:56
@jrushlow jrushlow mentioned this pull request May 23, 2023
weaverryan added a commit that referenced this pull request Jun 7, 2023
This PR was merged into the 1.0-dev branch.

Discussion
----------

[git-released] v1.49.0

# Changelog

## [v1.49.0](https://github.com/symfony/maker-bundle/releases/tag/v1.49.0)

*Jun 7th, 2023*

### Feature

- [#1321](#1321) - Changing make:stimulus-controller to require StimulusBundle - *`@weaverryan`*
- [#1309](#1309) - Apply `get_class_to_class_keyword` PHP-CS-Fixer rule - *`@seb`-jean*
- [#1276](#1276) - [make:migration] Change message when required package for migration doesn't exist. - *`@bdaler`*
- [#1261](#1261) - [make:registration-form] use UniqueEntity attribute instead of annotation - *`@jrushlow`*
- [#1253](#1253) - [make:migration] Add link to new migration files - *`@nicolas`-grekas*
- [#1251](#1251) - [make:*] use php-cs-fixer to style/lint all generated php templates - *`@jrushlow`*
- [#1244](#1244) - [make:security:form-login] new maker to use built in FormLogin - *`@jrushlow`*
- [#1242](#1242) - [make:*] use static return type instead of self for setters - *`@jrushlow`*
- [#1239](#1239) - Improve error messages to show PHP & XML configurations are not supported - *`@ThomasLandauer`*
- [#1238](#1238) - [make:*] improve output messages for Symfony CLI users - *`@jrushlow`*
- [#1237](#1237) - [make:registration-form] Print registration form errors - *`@comxd`*
### Bug

- [#1307](#1307) - [make:twig-component] handle upstream changes to how live components are rendered - *`@jrushlow`*
- [#1270](#1270) - [make:authenticator] Core\Security or SecurityBundle\Security - Avoid deprecations in 6.2 - *`@nacorp`*
- [#1265](#1265) - [make:crud] Make sensio/framework-extra-bundle an optional dependency - *`@acrobat`*
- [#1264](#1264) - [make:controller] doctrine/annotations is not needed - *`@jrushlow`*
- [#1262](#1262) - [make:reset-password] doctrine/annotations are not needed - *`@jrushlow`*

_Generated by Git Released_

Commits
-------

a7bb5c6 Updating date, adding 1 more PR
cb06c33 [release] v1.49.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant