Skip to content

[make:user] add the void return type to eraseCredentials() #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2023

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented May 23, 2023

In 6.3 tests - handle:

Method "Symfony\Component\Security\Core\User\UserInterface::eraseCredentials()" might add "void" 
as a native return type declaration in the future. Do the same in implementation "App\Entity\User" now
 to avoid errors or add an explicit @return annotation to suppress this message.

@jrushlow jrushlow added Feature New Feature Status: Needs Review Needs to be reviewed labels May 23, 2023
@jrushlow jrushlow marked this pull request as ready for review May 23, 2023 13:50
@weaverryan weaverryan force-pushed the feature/6.3-deprecations branch from da70c9c to 39fe9cd Compare May 30, 2023 17:05
@weaverryan
Copy link
Member

Thanks Jesse!

@weaverryan weaverryan merged commit 4bd4868 into symfony:main May 30, 2023
@jrushlow jrushlow deleted the feature/6.3-deprecations branch March 4, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants