bump phpunit-bridge version constraint #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
force-pushed
the
fix/5.4-lowest-tests
branch
from
deaa169 to
032fd45
Compare
jrushlow
added
Bug
Merged
|
Thanks Jesse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v5.4.17ofphpunit-bridgefixed compatibility withdoctrine/annotations:^2.0.https://github.com/symfony/symfony/pull/48718/files#diff-7b61897762550adef47d038e61dbb44e9759b80179c8c7674fc2300c207fe751
Without the version bump to at least
5.4.17- CI fails against5.4.*w/--prefer-lowestdependencies.phpunit-bridge:^5.4.7is the lowest, but not compatible w/ MakerBundle asdoctrine/annotationsisn't needed.Fixes:
in several tests.