Fix the EntityRegenerator on Mac #179
Conversation
| @@ -43,7 +44,7 @@ public function regenerateEntities(string $classOrNamespace) | |||
| { | |||
| try { | |||
| $metadata = $this->doctrineHelper->getMetadata($classOrNamespace); | |||
| } catch (MappingException $mappingException) { | |||
| } catch (MappingException | CommonMappingException $mappingException) { | |||
There was a problem hiding this comment.
Excluding this file on PHP 7 makes Travis happy!
This cause PHP CS Fixer's linting to fail on PHP 7 because this syntax is supported only since PHP 7.1. However the make:entity command already requires 7.1.
Do you want me to use multiple catch blocks or just to ignore this file in the PHP CS config on PHP 7?
|
The |
|
|
|
@dunglas , ah, indeed. The current fix seems to work for me just fine. |
|
Fantastic! Super weird, but the code/fix gives us code that still makes sense: if there’s a mapping exception in general, fallback to the disconnected metadata lookup. Hopefully this will unblock some things! |
On Mac, an instance of
Doctrine\Common\Persistence\Mapping\MappingExceptionis thrown by Doctrine when a mapping file references a non-existing class. Currently, the code only catchesDoctrine\ORM\Mapping\MappingExceptioninstances.This PR makes the tests green on Mac (#167 (comment)). This also probably fixes a real bug.
I've no idea why Doctrine throws a different exception on Mac than on Linux.