fix: add src option for not standard paths #185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rampmaster
force-pushed
the
fix_custom_src
branch
from
6c98ef2 to
784ad8d
Compare
|
Hi there! I agree that we can make this better :). But, I think there is a different solution that is better for DX. Instead of using Finder to look in the src/ directory, we should read the Doctrine metadata to load a real list of all of the entities. This should not be too difficult by using the DoctrineHelper class. Then, you will get the nice functionality without needing to know about or pass an option. Do you want to update your PR to try this? Cheers! |
|
Yes, not problem @weaverryan and thanks for your idea :-) |
|
@rampmaster Hey, any chance updating this PR? I need this feature. |
|
Yes, working. |
|
Hi @rampmaster ! I was about to create the same fix ^^ |
weaverryan
added a commit
that referenced
this pull request
Dec 20, 2018
This PR was squashed before being merged into the 1.0-dev branch (closes #311). Discussion ---------- Fix Entity directory does not exist Closes #299 according to #185 (comment) Also alternative for #185, #265 and #310 Commits ------- 5f37c5d Remove invalid field mapping 06f5399 Invalidating cached AnnotationDriver::$classNames to find new entities 8b7c291 Fix 'src/Entity' directory does not exist
saylor-mik87786
added a commit
to saylor-mik87786/maker-bundle
that referenced
this pull request
Jun 3, 2025
This PR was squashed before being merged into the 1.0-dev branch (closes #311). Discussion ---------- Fix Entity directory does not exist Closes #299 according to symfony/maker-bundle#185 (comment) Also alternative for symfony/maker-bundle#185, symfony/maker-bundle#265 and symfony/maker-bundle#310 Commits ------- 5f37c5d Remove invalid field mapping 06f5399 Invalidating cached AnnotationDriver::$classNames to find new entities 8b7c291 Fix 'src/Entity' directory does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add custom option
srcfor entity generator