Skip to content

Fix: No need to specify preferred installation method on Travis #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2018

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented May 18, 2018

This PR

  • removes the --prefer-dist option when running composer install on Travis
  • simplifies the configuration for preferred-install in composer.json

πŸ’β€β™‚οΈ It's already configured in composer.json.

@localheinz localheinz force-pushed the fix/preferred-install branch from b4e4acc to c2e444a Compare May 18, 2018 12:19
@weaverryan
Copy link
Member

Thank you @localheinz!

@weaverryan weaverryan merged commit 98d8ca1 into symfony:master Jun 13, 2018
weaverryan added a commit that referenced this pull request Jun 13, 2018
…ravis (localheinz)

This PR was squashed before being merged into the 1.0-dev branch (closes #189).

Discussion
----------

Fix: No need to specify preferred installation method on Travis

This PR

* [x] removes the `--prefer-dist` option when running `composer install` on Travis
* [x] simplifies the configuration for `preferred-install` in `composer.json`

πŸ’β€β™‚οΈ It's already configured in [`composer.json`](https://github.com/symfony/maker-bundle/blob/bb0485a3b2eecc561eff735109316677e18fb1d1/composer.json#L35-L37).

Commits
-------

98d8ca1 Fix: Simplify configuration
c2e444a Fix: No need to specify preferred installation method on Travis
@localheinz localheinz deleted the fix/preferred-install branch June 13, 2018 14:18
@localheinz
Copy link
Contributor Author

Thank you, @weaverryan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants