make:crud | Improvements #241
Conversation
src/GeneratorTwigHelper.php
Outdated
| case 'datetime': | ||
| $printCode .= ' ? '.$printCode.'|date(\'Y-m-d H:i:s\') : \'\''; | ||
| break; | ||
| case 'dateinterval': | ||
| $printCode .= ' ? '.$printCode.'.format(\'%y years, %m month, %d days\') : \'\''; |
There was a problem hiding this comment.
What about ('%y year(s), %m month(s), %d day(s)') ?
|
How about adding new test cases to make sure these behave as intended? |
| case 'json': | ||
| case 'json_array': | ||
| $printCode .= ' is iterable ? '.$printCode.'|join(\', \') : '.$printCode; | ||
| break; |
There was a problem hiding this comment.
Interesting! From looking at the docs, it seems like the value in this field will always be an array or null. Which case were you covering with the is iterable?
And, because the array can be an associative array, the |join won't look quite right in those cases. We could use dump() WDYT?
There was a problem hiding this comment.
I'll check it again. I thought there could be string value.
dump() is a good idea, but will it work without debug package?
There was a problem hiding this comment.
It believe that it DOES work without debug - it reverts to var_dump(). We can add a json field to our entity in the functional test to be sure.
There was a problem hiding this comment.
Oh, you know what? Let's use |json_encode. That will print nicely, and make it very obvious that this is a JSON field. And, it will definitely work :).
@sadikoff if you agree, can you make that change? Also, if you rebase from the latest master, the tests should be closer to passing.
I agree! And actually, this test could be even a little bit cooler if we actually "rendered" the result through Twig (passing in some real |
sadikoff
changed the title
|
@sadikoff Can you rebase this? I want to make sure the tests pass with the latest changes on master. Also, there are 2 changes in this PR to |
|
@weaverryan ok, I'll rebase it P.S. I think travis will be more stable with this changes |
|
Thanks Vladimir! |
Added datetimetz, *_immutable, dateinterval and json fileds processing.
closes #234
closes #270