Remove Symfony Flex dependency from MakerBundle #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @danrot! Yea, the bundle is more flexible in this regard than it was originally - so the note was out of date. Cheers! |
weaverryan
added a commit
that referenced
this pull request
Dec 20, 2018
…eaverryan) This PR was merged into the 1.0-dev branch. Discussion ---------- Remove Symfony Flex dependency from MakerBundle We have been confused because the documentations states that Symfony Flex is required in order to use the MakerBundle. However, we are not using Symfony Flex in our application yet, but it was still possible to use the MakerBundle. So I would suggest to remove the part saying that Symfony Flex is a dependency. Commits ------- ee422ec adding message about dir structure 42f89c2 Update index.rst 145653d Remove Symfony Flex dependency from MakerBundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been confused because the documentations states that Symfony Flex is required in order to use the MakerBundle.
However, we are not using Symfony Flex in our application yet, but it was still possible to use the MakerBundle. So I would suggest to remove the part saying that Symfony Flex is a dependency.