Change the base class for Doctrine repositories #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
doctrine-tweak
branch
from
8207b80 to
1b6beda
Compare
| { | ||
| public function __construct(RegistryInterface $registry) | ||
| { | ||
| parent::__construct($registry, {{ repository_class_name }}::class); |
There was a problem hiding this comment.
I the explicitness, but maybe it's not great if people rename the class at some point.
fabpot
force-pushed
the
doctrine-tweak
branch
from
1b6beda to
9ac02ce
Compare
fabpot
force-pushed
the
doctrine-tweak
branch
from
9ac02ce to
4f0114d
Compare
nicolas-grekas
approved these changes
Nov 11, 2017
ogizanagi
approved these changes
Nov 11, 2017
fabpot
added a commit
that referenced
this pull request
Nov 11, 2017
This PR was merged into the master branch. Discussion ---------- Change the base class for Doctrine repositories Commits ------- 4f0114d changed the base class for Doctrine repositories
xabbuh
reviewed
Nov 13, 2017
| { | ||
| public function __construct(RegistryInterface $registry) |
There was a problem hiding this comment.
The parent class constructor only expects an instance of Doctrine\Common\Persistence\ManagerRegistry. Do we really want to restrict that here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.