Yaml source manipulator - fix access control #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryPEGEOT
reviewed
Nov 4, 2019
Comment on lines
+466
to
+469
| $isNextContentComment = $this->isPreviousLineComment($newPosition); | ||
| if ($isNextContentComment) { | ||
| $newPosition++; | ||
| } |
There was a problem hiding this comment.
Shouldn't it be a while in case of multi-line comment?
There was a problem hiding this comment.
The $newPosition++ here is just because of the code below that adds 1 new character (\n) if the next line is a comment. I'm moving this pointer/position forward 1 for that 1 \n. It's confusing code :). The test case actually does have 2 lines of comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps #460 by fixing a few bugs with YamlSourceManipulator. But, it doesn't yet allow for the
access_controlarray structure to be printed in an inline format (#460 (comment)).Cheers!