Skip to content

[sfhackday2019] Fixing tests #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 23, 2019
Merged

[sfhackday2019] Fixing tests #497

merged 4 commits into from
Nov 23, 2019

Conversation

sadikoff
Copy link
Contributor

Improve symlinking phpunit-bridge inside testing flex project.

@romaricdrigon romaricdrigon added Bug Bug Fix DX Status: Waiting Feedback Needs feedback from the author labels Nov 23, 2019
Copy link
Contributor

@romaricdrigon romaricdrigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are in a better state ; there are some SF5-related issues, but those are also on master.

@weaverryan
Copy link
Member

Thank you for your detailed work on this Vladimir and Romaric - really happy to have the tests in a better state (even if we're waiting for some Symfony5-related tthings still)

@weaverryan weaverryan merged commit 4712a5d into symfony:master Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix DX Status: Waiting Feedback Needs feedback from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants