Fixing tests for Symfony5 #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
matrix-sf4-sf5
branch
3 times, most recently
from
975dcf9 to
121ae77
Compare
weaverryan
changed the title
weaverryan
force-pushed
the
matrix-sf4-sf5
branch
from
a88ff32 to
7132a38
Compare
* tweaking the test matrix to test Symfony 4, Symfony 5 & change DEV to allow_failure * Fixing arrangement of createClient() and booting the kernel * Fix bug where object type-hint in listener tricked make:subscriber * making test work for PHP 7.1 and lower * avoiding 3 tests in PHP 7.1 due to seg-faulting * fixing phpcs * adding a workaround for an odd failing test * fixing the dev version tests
weaverryan
force-pushed
the
matrix-sf4-sf5
branch
from
aae6815 to
56df019
Compare
weaverryan
added a commit
that referenced
this pull request
Dec 5, 2019
This PR was merged into the 1.0-dev branch. Discussion ---------- Fixing tests for Symfony5 This also removes the dev-stable. That was a build to detect possible BC breaks on patch versions made in Symfony... which is rare and probably not the job of Maker :). Commits ------- 56df019 Various test fixes & matrix improvements:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the dev-stable. That was a build to detect possible BC breaks on patch versions made in Symfony... which is rare and probably not the job of Maker :).