Skip to content

explicitly set framework.router.utf8 value in test kernel #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Mar 27, 2020

fixes Since symfony/framework-bundle 5.1: Not setting the "framework.router.utf8" configuration option is deprecated, it will default to "true" in version 6.0. deprecation warning in tests / ci

not intended to address any other deprecation's or fix/refactor other logic

@jrushlow jrushlow marked this pull request as ready for review March 27, 2020 20:26
@weaverryan
Copy link
Member

Thanks Jesse!

@weaverryan weaverryan merged commit b08e15f into symfony:master Mar 28, 2020
weaverryan added a commit that referenced this pull request Apr 5, 2020
…ushlow)

This PR was squashed before being merged into the 1.0-dev branch (closes #567).

Discussion
----------

create maker for symfony casts reset password bundle

Adds a `make:reset-password` maker to create the classes, entities, and twig templates required by Symfony Casts Reset Password Bundle. This complements the bundle by doing the leg work to provide a true out-of-the-box solution for handling forgotten passwords in traditional Symfony applications.

- [x] test suite depends on PR #565
- [x] depends on flex recipe symfony/recipes#748

Commits
-------

bb1438b create maker for symfony casts reset password bundle
@jrushlow jrushlow deleted the ci-fix/router-utf8 branch April 16, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants