Skip to content

[make:validator] Fix @var typehint comments #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2022
Merged

[make:validator] Fix @var typehint comments #830

merged 3 commits into from
Feb 23, 2022

Conversation

mmarton
Copy link
Contributor

@mmarton mmarton commented Mar 3, 2021

Hi!

I found some malformed @var typehint comments in the code annd fixed them.

(This is my first PR)

mmarton
mmarton commented Mar 3, 2021
View reviewed changes
mmarton
mmarton commented Mar 3, 2021
View reviewed changes
jrushlow
jrushlow requested changes Mar 12, 2021
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmarton!

@jrushlow jrushlow added DX Status: Needs Work Additional work is needed labels Mar 12, 2021
@mmarton mmarton force-pushed the fix/typehint-comments branch from e44ccea to 16dd858 Compare March 12, 2021 12:37
@mmarton
Copy link
Contributor Author

mmarton commented Mar 12, 2021

@jrushlow I updated the commented parts, but it's still failing.

jrushlow
jrushlow requested changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmarton This looks good! I believe there is a bug in cs fixer that is causing the tests to fail. Using the inline comment /* instead of the inline docBlock /** will take care of our CI and everything will be all set.

jrushlow
jrushlow requested changes Mar 15, 2021
View reviewed changes
@mmarton mmarton requested a review from jrushlow March 29, 2021 18:17
Misley Márton and others added 3 commits February 23, 2022 12:52
@jrushlow jrushlow force-pushed the fix/typehint-comments branch from 5bb336a to de52eb8 Compare February 23, 2022 19:12
jrushlow
jrushlow approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mmarton!

@jrushlow jrushlow added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Work Additional work is needed labels Feb 23, 2022
@jrushlow jrushlow changed the title Fix @var typehint comments [make:validator] Fix @var typehint comments Feb 23, 2022
@jrushlow jrushlow merged commit ded06ef into symfony:main Feb 23, 2022
@jrushlow jrushlow mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
DX Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmarton @jrushlow