make PhpCompatUtil::getPhpVersion() public

[nikophil]

Hello,

what do you think if we make the method PhpCompatUtil::getPhpVersion() public?

This could be needed for some libs which leverage maker bundle

This would be helpful to resolve this problem: api-platform/core#4423 (review)

Another solution for my problem would be to expose a global is_php8 variable to all templates. but maybe that's not a good solution, because way may need to differentiate minor versions

[jrushlow]

We already have a global use_attributes & use_typed_properties variable available in the maker templates -

maker-bundle/src/Generator.php

Line 175 in 203699d

$variables['use_typed_properties'] = $this->phpCompatUtil->canUseTypedProperties();

What additional features are needed in PHP8 that are not covered by these 2 methods? If union return types is needed, adding a public canUseUnionTypes(): bool method would be the way to go (although redundant) vs. opening up the getPhpVersion() scope as the class itself is internal.

[nikophil]

Hello @jrushlow

thanks for your feedback. I indeed felt it was a little bit redundant, and not flexible enough.

Here is a fix. Cheers!

[weaverryan]

Thanks Nicolas - I like where this ended up :)