Skip to content

Instead of Unpack the Pack - use tags for update strategies #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2020
Merged

Instead of Unpack the Pack - use tags for update strategies #30

merged 1 commit into from
Jul 14, 2020

Conversation

nusphere
Copy link
Contributor

@nusphere nusphere commented Jul 9, 2020 •
edited
Loading

make a new major tag for a full Support of Doctrine Migration V3

@nusphere
Update composer.json
93d911c 
Revert Sticky to V2 and generates a full Support of Doctrine Migration V3
@nusphere
Copy link
Contributor Author

nusphere commented Jul 9, 2020 •
edited
Loading

Lets tag the as symfony/orm-pack: 2.0.0

Reason:
the latest version of an pack should be the up-to-date version of the containing packages. A stick to V2 is the wrong way - until a unpack losing the idea of the dependencies. If someone add a new dependency to this pack - all unpacked versions of this pack will do not require this dependency.

Instead of make the latest pack version sticky, serve 2 versions of this pack. a sticky and a updated one.

@nusphere
Copy link
Contributor Author

nusphere commented Jul 9, 2020

I need to use "symfony/orm-pack": "1.0.8 || ^2.0" for now

@nusphere nusphere mentioned this pull request Jul 9, 2020
Closed
@nusphere
Copy link
Contributor Author

nusphere commented Jul 9, 2020

reference to #29

nicolas-grekas
nicolas-grekas reviewed Jul 9, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will reintroduce issues like #25 and #18. These cannot be just ignored.
Here are some suggestions to help move forward.

composer.json
"doctrine/doctrine-bundle": "^2",
"doctrine/doctrine-migrations-bundle": "^2"
"doctrine/orm": "*",
"doctrine/doctrine-bundle": "*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both these lines must be kept as is: when dbal/orm v3 will be released, adopting them should be opt-in

composer.json
"doctrine/doctrine-migrations-bundle": "^2"
"doctrine/orm": "*",
"doctrine/doctrine-bundle": "*",
"doctrine/doctrine-migrations-bundle": "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use ^3

@nicolas-grekas nicolas-grekas mentioned this pull request Jul 9, 2020
Merged
nicolas-grekas
nicolas-grekas approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to me as is once symfony/flex#656 is merged + tagged.

To be tagged as v2.0.0

@nicolas-grekas
Copy link
Member

Now that symfony/recipes#797 is merged, the path is clear.

@nicolas-grekas nicolas-grekas merged commit 46aa731 into symfony:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nusphere @nicolas-grekas