Multiple Set-Cookie Headers in Symfony Response. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some tests? |
|
ping @tinyroy :) Any news here? |
stof
reviewed
Oct 20, 2016
| @@ -64,7 +64,11 @@ public function getHeaderLine($name) | |||
|
|
|||
| public function withHeader($name, $value) | |||
| { | |||
| throw new \BadMethodCallException('Not implemented.'); | |||
| if (is_string($value) || is_array($value)) { | |||
| $this->headers[$name] = $value; | |||
There was a problem hiding this comment.
wrong implementation. If the value is a string, you need to wrap it in an array. Otherwise, getHeader will not return an array
nicolas-grekas
added a commit
that referenced
this pull request
Mar 11, 2019
… to a Symfony header cookie (tinyroy) This PR was merged into the 1.2-dev branch. Discussion ---------- removed 'Set-Cookie' from header when it is already converted to a Symfony header cookie Fix #25 Fix #26 Commits ------- dd1111e removed 'Set-Cookie' from header when it is already converted to a Symfony header cookie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25