Convert Request/Response multiple times #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but let's replace |
|
Thank you for the review. Rebased! |
|
Fabbot is happy =) Just going to fix the test.. Doing it now |
|
Tests should be green now |
nicolas-grekas
force-pushed
the
multi-convert
branch
from
4e92add to
8564bf7
Compare
|
Thank you @Nyholm. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 11, 2019
This PR was squashed before being merged into the 1.2-dev branch (closes #48). Discussion ---------- Convert Request/Response multiple times By doing this we make sure that we do not loose data. Im not sure if this is a good idea or even the intention of the bridge. Could someone give me a thumbs up before I start trying to fix the tests? Commits ------- 8564bf7 Convert Request/Response multiple times
jibran
reviewed
Mar 24, 2019
| @@ -141,7 +141,7 @@ protected function getTemporaryPath() | |||
| public function createResponse(ResponseInterface $psrResponse) | |||
| { | |||
| $cookies = $psrResponse->getHeader('Set-Cookie'); | |||
| $psrResponse = $psrResponse->withHeader('Set-Cookie', []); | |||
There was a problem hiding this comment.
I think this should be backported to 1.1.1 because it doesn't work with zendframework/zend-diactoros:1.8.6 which requires PHP 7.0
There was a problem hiding this comment.
See https://www.drupal.org/project/drupal/issues/3039611#comment-13037090 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doing this we make sure that we do not loose data.
Im not sure if this is a good idea or even the intention of the bridge. Could someone give me a thumbs up before I start trying to fix the tests?