Skip to content

[league/oauth2-server-bundle] Ignore generated public and private keys #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fbourigault
Copy link
Contributor

Q A
License MIT
Doc issue/PR N/A

Keys must not be committed!

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 13, 2022 10:17
@github-actions
Copy link

github-actions bot commented Oct 13, 2022

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1133/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1133/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'league/oauth2-server-bundle:^0.4'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@fbourigault fbourigault changed the title Add generated public and private keys to .gitignore [league/oauth2-server-bundle] Add generated public and private keys to .gitignore Oct 13, 2022
@fbourigault fbourigault changed the title [league/oauth2-server-bundle] Add generated public and private keys to .gitignore [league/oauth2-server-bundle] Ignore generated public and private keys Oct 13, 2022
fabpot
fabpot previously approved these changes Oct 15, 2022
chalasr
chalasr previously approved these changes Oct 15, 2022
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@symfony-recipes-bot symfony-recipes-bot merged commit 52b78a5 into symfony:main Oct 20, 2022
@fbourigault fbourigault deleted the league-oauth-gitignore branch October 20, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants