[DoctrineBundle] resolve parameters inside DATABASE_URL

[nicolas-grekas]

Q	A
License	MIT

Not ready to merge yet, because this relies on DI >=3.4.
If we want to allow this with 3.3, we might patch DoctrineBundle.
But before doing so, what about just moving to require >=3.4 for all Symfony components?
Any other idea?

[symfony-bot]

Pull request passes validation.

[aik099]

Actually I don't like DATABASE_URL as single DSN for database, because it only works with Doctrine and doesn't work with PdoSessionHandler, that expects DSN in different format and username/password as separate variables.

I wish we could revert back to use 4 env variables as in Symfony 3.3 (that's what I did for now in my project to avoid specifying DB credentials in 2 different formats).

[javiereguiluz]

Could we fix PdoSessionHandler to support this new DSN format instead?

[aik099]

The DSN format isn't new, but isn't standard PDO DSN either. Not sure how to do this without breaking BC, but I see 2 options:

1. either duplicate Doctrine DSN parser (for all DB types) in PdoSessionHandler

pros: PdoSessionHandler works with Doctrine bundle not installed
cons: code duplication

2. or make PdoSessionHandler literally share connection that Doctrine creates

pros: you will see DB queries made by PdoSessionHandler in Web Profiler
cons: PdoSessionHandler would depend on DoctrineBundle

P.S.
If Doctrine has DSN parser as standalone package, then we can use it. Haven't checked.

[nicolas-grekas]

@aik099 please open an issue if you want to discuss this, that's another topic.

[aik099]

Created #206.

[aik099]

Will the resolve: prefix work for Symfony 3.3 as well?

[fabpot]

We need to decide what to do here. I think we should probably just merge as is and let 3.3 users behind.

[weaverryan]

I don't see any other option. We could temporarily (until 3.4 is released) add a comment above this line:

For Symfony 3.3, remove the "resolve:" part: parameters cannot live inside environment vars

[fabpot]

Problem is that cache:clear will fail immediately as the syntax is not valid in 3.3.

[fabpot]

So?

[fabpot]

Can you add a comment for people using 3.3? Something like # If you are using Symfony 3.3, remove the resolve: prefix

[ghost]

Pull request passes validation.