Enable container.dumper.inline_class_loader param by default #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
dunglas
approved these changes
Nov 10, 2017
| @@ -37,6 +37,7 @@ public function registerBundles() | |||
| protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader) | |||
| { | |||
| $container->setParameter('container.autowiring.strict_mode', true); | |||
| $container->setParameter('container.dumper.inline_class_loader', true); | |||
There was a problem hiding this comment.
Can't it be set to on by default in 4.0?
There was a problem hiding this comment.
it is in the flex recipe, would be a hard BC break otherwise
There was a problem hiding this comment.
We should still work on making this on by default in the future (we could trigger a deprecation notice in 3.4 if the parameter is not set explicitly to either true or false, saying that the default behavior in 4.0 would be to enable this).
container.autowiring.strict_mode does not suffer from this, because it is just about disabling a BC layer (so it is gone entirely in 4.0)
|
rebased |
fabpot
approved these changes
Nov 10, 2017
ghost
pushed a commit
that referenced
this pull request
Nov 10, 2017
leofeyer
pushed a commit
to contao/contao
that referenced
this pull request
Jan 9, 2020
…1162) Description ----------- These parameters are on by default since Symfony 3.3 symfony/recipes#241 Commits ------- f653aee Remove obsolete parameters d64dda0 Re-add container.dumper.inline_class_loader
leofeyer
pushed a commit
to contao/manager-bundle
that referenced
this pull request
Jan 9, 2020
…1162) Description ----------- These parameters are on by default since Symfony 3.3 symfony/recipes#241 Commits ------- f653aeeb Remove obsolete parameters d64dda0d Re-add container.dumper.inline_class_loader
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling to symfony/symfony#24872