Skip to content

Use $this->getProjectDir() instead of dirname(__DIR__) #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Nov 10, 2017
Merged

Use $this->getProjectDir() instead of dirname(__DIR__) #244

1 commit merged into from
Nov 10, 2017

Conversation

rosier
Copy link
Contributor

@rosier rosier commented Nov 10, 2017

Q A
License MIT

Replace dirname(__DIR__) in App\Kernel with $this->getProjectDir()

ghost
ghost approved these changes Nov 10, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@rosier rosier mentioned this pull request Nov 10, 2017
Closed
@ghost ghost merged commit 2bb4ff0 into symfony:master Nov 10, 2017
ghost pushed a commit that referenced this pull request Nov 10, 2017
Merge pull request #244
04b4e27
@yceruto yceruto mentioned this pull request Nov 13, 2017
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Pierstoval Pierstoval Pierstoval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rosier @fabpot @nicolas-grekas @Pierstoval