Skip to content

Move routes config for annotations #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Nov 18, 2017
Merged

Move routes config for annotations #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doctrine/annotations/1.0/config/routes/annotations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
controllers:
resource: ../src/Controller/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is relative to %kernel.root_dir% it should be just Controller/

Copy link
Member

@yceruto yceruto Nov 21, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's relative to the entry point (public/index.php or bin/console) where the kernel is instantiated.

type: annotation
5 changes: 5 additions & 0 deletions doctrine/annotations/1.0/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/"
}
}
5 changes: 0 additions & 5 deletions symfony/routing/3.3/config/routes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
#index:
# path: /
# defaults: { _controller: 'App\Controller\DefaultController::index' }

# first, run composer req annotations
#controllers:
# resource: ../src/Controller/
# type: annotation