Recommend specifying the controller itself for EasyAdmin #30
Conversation
|
pings @javiereguiluz |
|
👍 this proposal makes sense to me! I've updated the official docs accordingly: https://github.com/javiereguiluz/EasyAdminBundle/pull/1604 Thanks @Pierstoval. Regarding the question about the versions, I don't really know yet what to do. I'd say, let's keep it as is for now. |
|
@javiereguiluz Thanks (check your emails, I need you :)) |
|
Thank you @Pierstoval. |
…ierstoval) This PR was merged into the master branch. Discussion ---------- Recommend specifying the controller itself for EasyAdmin I think it's a better idea to expose the controller itself directly. It would encourage people to add their own controller by just changing the name of the bundle if they want to override it. Also, I would suggest to change `master` for a lower requirement (1.14 or 1.15 maybe, there are some without much BC breaks, and they'd still share the same recipe) and add `version_aliases`, but haven't done it in the PR because `master` might have been added for a specific reason 🙂 Commits ------- b7d9955 Recommend specifying the controller itself for EasyAdmin
@fabpot is there anything regarding the "stability" of a Flex recipe like there is for Composer packages stability? (stable, beta, dev, etc.) |
|
There is no stability for a recipe, it can only be stable (the underlying package can have a stability, but not recipes). Also, keep in mind that it works only for deps > Symfony 3.3. So, we can only support bundles that work with Symfony 3.3+. |
|
Ok, so EasyAdmin will have to maintain a new branch for Symfony |
…ereguiluz) This PR was merged into the master branch. Discussion ---------- [Doc] Always load the specific EasyAdmin controller In symfony/recipes#30 @Pierstoval proposes to use the explicit controller instead of the `Controller/` directory. I think it makes a lot of sense, so let's update the docs. Commits ------- b9d3d18 [Doc] Always load the specific EasyAdmin controller
|
@Pierstoval you can have a branch supporting 2.8+, as long as 3.3 works. |
|
Yep, this can be checked via composer version constraints so this is no issue actually |
I think it's a better idea to expose the controller itself directly.
It would encourage people to add their own controller by just changing the name of the bundle if they want to override it.
Also, I would suggest to change
masterfor a lower requirement (1.14 or 1.15 maybe, there are some without much BC breaks, and they'd still share the same recipe) and addversion_aliases, but haven't done it in the PR becausemastermight have been added for a specific reason 🙂