Skip to content

Readme tweaks #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2017
Merged

Readme tweaks #34

merged 2 commits into from
Apr 27, 2017

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Apr 27, 2017

No description provided.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


Don't create a recipe for Symfony bundles if the only configuration in the
manifest is the registration of the bundle for all environments, as this is
done automatically.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should mention that this is done automatically when there is no recipe.

If there is a recipe to configure extra things, it must still register the bundle

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make the note heavy. I think people will realize that.

@fabpot fabpot merged commit 15027c7 into master Apr 27, 2017
fabpot added a commit that referenced this pull request Apr 27, 2017
This PR was squashed before being merged into the master branch (closes #34).

Discussion
----------

Readme tweaks

Commits
-------

15027c7 added a note about the auto-registration of Symfony bundles
5088124 removed most mentions of Flex in the README
@fabpot fabpot deleted the readme-tweaks branch April 27, 2017 19:07
VolCh pushed a commit to VolCh/recipes that referenced this pull request Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants