[DX] Set default_table_options to match default utf8mb4 charset #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `default_table_options` options should match the default charset `utf8mb4` so the migrations will generate each table with `utf8mb4` + `utf8mb4_unicode_ci` instead of `utf8` + `utf8_unicode_ci`, so users don't have to specify the `table_options` for each entity.
Pierstoval
approved these changes
Mar 19, 2018
|
Closing as a duplicate of #368 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
default_table_optionsoptions should match the default charsetutf8mb4so the migrations will generate each table withutf8mb4+utf8mb4_unicode_ciinstead ofutf8+utf8_unicode_ci, so users don't have to specify thetable_optionsfor each entity.