Remove "--relative" and "--symlink" options by default #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
stof
approved these changes
Jun 1, 2018
There was a problem hiding this comment.
In a Flex project, installed assets are only the third-party ones (as there is no project-level bundle), that you will not edit directly. So copying the assets by default looks sensible to me. It solves issues with Docker mounts (#398) and does not decrease DX for normal workflows (if you never edit the third-party assets manually, any change to them would be done by composer updating the package, and the assets would be reinstalled then).
So 👍 for me.
covex-nn
approved these changes
Jun 1, 2018
weaverryan
approved these changes
Jun 1, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #398