Enable utf8 mode for the router on 4.2 #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Jul 6, 2018
maxhelias
approved these changes
Jul 6, 2018
xabbuh
reviewed
Jul 6, 2018
| @@ -0,0 +1,3 @@ | |||
| #index: | |||
| # path: / | |||
| # controller: App\Controller\DefaultController::index | |||
There was a problem hiding this comment.
Shouldn't this be just one colon?
There was a problem hiding this comment.
didn't we deprecate the single colon syntax? this is the same file as for lower versions btw
There was a problem hiding this comment.
same as in the other PR: I did confuse what we deprecated 🙈
ghost
deployed
to
fabpot
approved these changes
Jul 11, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling to symfony/symfony#27774