Skip to content

disable route annotations with SensioFrameworkExtraBundle 5.2 #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jul 9, 2018

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 7, 2018

Q A
License MIT

see sensiolabs/SensioFrameworkExtraBundle#562

Credits go to @mehranhadidi who made me aware of this in the Symfony Slack.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

"Sensio\\Bundle\\FrameworkExtraBundle\\SensioFrameworkExtraBundle": ["all"]
},
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid character '}' looking for beginning of object key string

@xabbuh xabbuh force-pushed the disable-routing-annotations branch from 2d4b5d7 to be584f6 Compare July 7, 2018 10:16
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@mehranhadidi
Copy link

Hope this is getting merged soon. The error is so annoying and confusing to fix for someone who is coming new to sf like me.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ghost ghost merged commit be584f6 into symfony:master Jul 9, 2018
ghost pushed a commit that referenced this pull request Jul 9, 2018
@xabbuh xabbuh deleted the disable-routing-annotations branch July 9, 2018 13:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants