Skip to content

Adding recipe for symfony/webpack-encore-bundle #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from
Nov 5, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
webpack_encore:
# The path where Encore is building the assets.
# This should match Encore.setOutputPath() in webpack.config.js.
output_path: '%kernel.project_dir%/public/build'
18 changes: 18 additions & 0 deletions symfony/webpack-encore-bundle/1.0/manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"bundles": {
"Symfony\\WebpackEncoreBundle\\WebpackEncoreBundle": ["all"]
},
"copy-from-recipe": {
"assets/": "assets/",
"config/": "%CONFIG_DIR%/",
"package.json": "package.json",
"webpack.config.js": "webpack.config.js"
},
"aliases": ["encore", "webpack", "webpack-encore"],
"gitignore": [
"/node_modules/",
"/%PUBLIC_DIR%/build/",
"npm-debug.log",
"yarn-error.log"
]
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"devDependencies": {
"@symfony/webpack-encore": "^0.20.0",
"@symfony/webpack-encore": "^0.21.0",
"webpack-notifier": "^1.6.0"
},
"license": "UNLICENSED",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ Encore
//.addEntry('page1', './assets/js/page1.js')
//.addEntry('page2', './assets/js/page2.js')

// will require an extra script tag for runtime.js
// but, you probably want this, unless you're building a single-page app
.enableSingleRuntimeChunk()

/*
* FEATURE CONFIG
*
Expand Down
7 changes: 0 additions & 7 deletions symfony/webpack-encore-pack/1.0/manifest.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
{
"copy-from-recipe": {
"assets/": "assets/",
"config/": "%CONFIG_DIR%/",
"package.json": "package.json",
"webpack.config.js": "webpack.config.js"
},
"aliases": ["encore", "webpack", "webpack-encore"],
"gitignore": [
"/node_modules/",
"/%PUBLIC_DIR%/build/",
Expand Down
7 changes: 7 additions & 0 deletions symfony/webpack-encore-pack/1.0/post-install.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<bg=yellow;fg=black> </>
<bg=yellow;fg=black> The symfony/webpack-encore-pack is no longer required anymore. Instead, use symfony/webpack-encore-bundle. </>
<bg=yellow;fg=black> </>

* <fg=blue>Instead</>:
1. Remove it now: <comment>composer remove symfony/webpack-encore-pack</>
2. Use Symfony's bridge: <comment>composer require encore</>