Skip to content

Remove "private" from defaults, it already is #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Oct 12, 2018
Merged

Remove "private" from defaults, it already is #473

1 commit merged into from
Oct 12, 2018

Conversation

nicolas-grekas
Copy link
Member

Q A
License MIT

ghost
ghost approved these changes Oct 12, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ghost ghost merged commit 4c3d490 into symfony:master Oct 12, 2018
ghost pushed a commit that referenced this pull request Oct 12, 2018
Merge pull request #473
0516ca4
@nicolas-grekas nicolas-grekas deleted the default-private branch November 9, 2018 13:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogizanagi ogizanagi ogizanagi approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @ogizanagi @chalasr