cast debug to boolean when creating kernel #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
nicolas-grekas
approved these changes
Nov 22, 2018
maxhelias
approved these changes
Nov 22, 2018
fabpot
approved these changes
Nov 22, 2018
ghost
pushed a commit
that referenced
this pull request
Nov 22, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to fix #481 (comment) by ensuring debug is cast to a bool, for those projects that may have enabled strict typing.
This restores the old behaviour which had a cast.
I am unsure if
src/.bootstrap.phpshould enforce the bool, or if should be cast at the last moment, like in this PS. please advise!