Fix the Travis build with multiple recipes #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
B-Galati
reviewed
Dec 8, 2018
| @@ -23,4 +23,4 @@ install: | |||
| - cd flex | |||
|
|
|||
| script: | |||
| - composer req "${PACKAGES}" | |||
| - composer req $(echo $PACKAGES) | |||
There was a problem hiding this comment.
Wouldn't it be the same without the double quotes instead of using echo?
There was a problem hiding this comment.
No, then all the line breaks in $PACAKGES will be printed.
There was a problem hiding this comment.
The previous code was passing all packages as a single argument to Composer. I tried without the double quotes, but the same happens (it looks like bash has some magical escaping there, for some reasons). That's the only way I found to have it working.
chalasr
approved these changes
Dec 9, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#SymfonyConHackday2018