Skip to content

[FrameworkBundle] split cache.yaml out of framework.yaml #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Dec 19, 2018
Merged

[FrameworkBundle] split cache.yaml out of framework.yaml #504

1 commit merged into from
Dec 19, 2018

Conversation

nicolas-grekas
Copy link
Member

Q A
License MIT

Might be clearer.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@weaverryan
Copy link
Member

Needs an issue in symfony-docs please. The docs are very sensitive to recipe changes :)

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Dec 11, 2018

grep framework.yaml * -r|grep cache yields no results - where should the doc be updated?

@weaverryan
Copy link
Member

On this page, for example: https://symfony.com/doc/current/configuration.html#configuration-config-packages

More largely the point is that if we don't create docs issues, the docs will get left behind. In this case, there is only one minor code block that needs to be updated :)

@nicolas-grekas
Copy link
Member Author

Doc PR sent: symfony/symfony-docs#10778

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Dec 13, 2018
…colas-grekas)

This PR was merged into the 4.1 branch.

Discussion
----------

Remove "cache" from example config of framework.yaml

Related to symfony/recipes#504

Commits
-------

8cf2ec7 Remove "cache" from example config of framework.yaml
@ghost ghost merged commit 7490f41 into symfony:master Dec 19, 2018
ghost pushed a commit that referenced this pull request Dec 19, 2018
@nicolas-grekas nicolas-grekas deleted the split-cache branch September 27, 2019 10:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants