Add .splitEntryChunks() to webpack.config.js #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
|
Yea, I kinda think we should. Everyone should now be using the Twig helpers, so you get this optimization “for free” by enabling this. |
weaverryan
approved these changes
Dec 23, 2018
maxhelias
approved these changes
Dec 23, 2018
bocharsky-bw
added a commit
to bocharsky-bw/webpack-encore-bundle
that referenced
this pull request
Dec 24, 2018
Now it's already enabled in the recipe, see symfony/recipes#509
|
@weaverryan Can take a look at docs later, but what do you mean about different output files in the “first example” page? We still have runtime.js, app.css, and app.js. We also mention entrypoints.json on that page too, though I don't see any mention for manifest.json there |
|
Hmm, you might be right that no changes are needed. I was thinking that some files might be “split” already - and so we might have a vendor~...js type of file. But probably there isn’t enough to cause splitting in that first chapter. +1 for this PR |
weaverryan
added a commit
to symfony/webpack-encore-bundle
that referenced
this pull request
Jan 17, 2019
…bocharsky-bw) This PR was merged into the master branch. Discussion ---------- Tweak docs: Now .splitEntryChunks() is enabled by default Now it's already enabled in the recipe, see symfony/recipes#509 Commits ------- 37c2deb Tweak docs: Now .splitEntryChunks() is enabled by default
javiereguiluz
approved these changes
Feb 19, 2019
ghost
pushed a commit
that referenced
this pull request
Feb 19, 2019
Keemosty12
added a commit
to Keemosty12/webpack-encore-bundle
that referenced
this pull request
Jun 12, 2025
Now it's already enabled in the recipe, see symfony/recipes#509
Keemosty12
added a commit
to Keemosty12/webpack-encore-bundle
that referenced
this pull request
Jun 12, 2025
…bocharsky-bw) This PR was merged into the master branch. Discussion ---------- Tweak docs: Now .splitEntryChunks() is enabled by default Now it's already enabled in the recipe, see symfony/recipes#509 Commits ------- 37c2deb Tweak docs: Now .splitEntryChunks() is enabled by default
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't we need adding .
.splitEntryChunks()as pointed in docs? See https://github.com/symfony/webpack-encore-bundle#usage