[webpack-encore-bundle] - update comments in default recipe for new features #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
|
ONLY MERGE IF if PR symfony/webpack-encore-bundle#56 is accepted |
PhilETaylor
changed the title
stof
reviewed
Apr 1, 2019
symfony/webpack-encore-bundle/1.0/config/packages/webpack_encore.yaml
Outdated
Show resolved
Hide resolved
Nyholm
changed the title
|
This can be merged as the upstream change has been merged in symfony/webpack-encore-bundle@2384cfd |
weaverryan
approved these changes
Apr 10, 2019
weaverryan
changed the title
chalasr
approved these changes
Apr 10, 2019
fabpot
approved these changes
Apr 10, 2019
ghost
suggested changes
Apr 10, 2019
|
@PhilETaylor Can you rebase this PR? It will then be merged automatically. Thank you. |
ghost
pushed a commit
that referenced
this pull request
Apr 10, 2019
|
Rebased and merged... 🎉 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes
update documentation for previous feature allowing output_path to be false
update documentation for new feature to set the value fo crossorigin attribute if PR propose fix for CORS issues with missing crossorigin tag webpack-encore-bundle#56 is accepted