Populate $_SERVER with $_ENV #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
This was referenced Apr 10, 2019
lyrixx
approved these changes
Apr 10, 2019
|
While you are right about thread safety this again introduces the problem that a system behaves different after calling The better solution would be to remove putenv from Dotenv, too. But that's not how it currently is. |
I agree with that but indeed it would be quite a BC break. |
|
Yep, unfortunately it is in the Symfony doc prior to 4.2, so it might be out in the wild. |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Apr 10, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #31062). Discussion ---------- [Dotenv] Deprecate useage of "putenv" | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | n/a From discussions on symfony/recipes#571, I think it is a good idea to make people opt-in to using `putenv`. In Symfony 5.0 we will just change the value of the constructor. As an alternative, we could decide we want to remove `putenv` in Symfony 5.0. If so, I would also deprecate `$usePutenv=true`. Commits ------- 8e45fc0 [Dotenv] Deprecate useage of \"putenv\"
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #540, fixes #532 (comment)